[
https://issues.apache.org/jira/browse/HBASE-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679129#comment-15679129
]
Hudson commented on HBASE-17088:
--------------------------------
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1980 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/1980/])
HBASE-17088 Refactor (zhangduo: rev fa7ed58e1bddc51d339587df99aa929aab53d7cd)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathBalancedQueueRpcExecutor.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRpcSchedulerFactory.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
> Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
> ----------------------------------------------------------------
>
> Key: HBASE-17088
> URL: https://issues.apache.org/jira/browse/HBASE-17088
> Project: HBase
> Issue Type: Improvement
> Components: rpc
> Affects Versions: 2.0.0
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17088-branch-1.patch, HBASE-17088-v1.patch,
> HBASE-17088-v2.patch, HBASE-17088-v3.patch, HBASE-17088-v3.patch,
> HBASE-17088-v4.patch, HBASE-17088-v4.patch
>
>
> 1. The RWQueueRpcExecutor has eight constructor method and the longest one
> has ten parameters. But It is only used in SimpleRpcScheduler and easy to
> confused when read the code.
> 2. There are duplicate method implement in RWQueueRpcExecutor and
> BalancedQueueRpcExecutor. They can be implemented in their parent class
> RpcExecutor.
> 3. SimpleRpcScheduler read many configs to new RpcExecutor. But the
> CALL_QUEUE_SCAN_SHARE_CONF_KEY is only needed by RWQueueRpcExecutor. And
> CALL_QUEUE_CODEL_TARGET_DELAY, CALL_QUEUE_CODEL_INTERVAL and
> CALL_QUEUE_CODEL_LIFO_THRESHOLD are only needed by AdaptiveLifoCoDelCallQueue.
> So I thought we can refactor it. Suggestions are welcome.
> Review board: https://reviews.apache.org/r/53726/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
