[
https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695043#comment-15695043
]
ramkrishna.s.vasudevan commented on HBASE-17048:
------------------------------------------------
bq.If so, bb.remaining() will give a wrong result. I have some doubt.
I think I asked the same question to Duo when that write(BB) was added. We do
some duplicate internally and then write to that. So I think that remaining
should be fine. But anyway I will take that remaining() to a local var and then
use it to avoid any confusion.
> Introduce a helper class to calcuate suitable ByteBuf size when allocating
> send buffer in FanOutOneBlockAsyncDFSOutputHelper
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-17048
> URL: https://issues.apache.org/jira/browse/HBASE-17048
> Project: HBase
> Issue Type: Sub-task
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-17012_3.patch, HBASE-17048.patch,
> HBASE-17048_1.patch
>
>
> As [~ram_krish] mentioned in HBASE-17021
> https://issues.apache.org/jira/browse/HBASE-17021?focusedCommentId=15646938&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15646938
> The default ByteBuf size is 256B which is too small.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
