[ 
https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695086#comment-15695086
 ] 

Anoop Sam John commented on HBASE-17048:
----------------------------------------

bq.We already know what length we want.
Fine. In that case, can ask alloc directly to do the allocation..  In other 
cases, we can ask the wrapper allocator of ours to do it. This is what u do now 
also..  Only thing is why can not pass alloc as constructor arg then so it will 
behave as if an allocator.  After every write to buf, we pass the  length for 
update again to the new allocator seems bit odd.  There is no way to get the 
bytesWritten from the buf itself?

> Introduce a helper class to calcuate suitable ByteBuf size when allocating 
> send buffer in FanOutOneBlockAsyncDFSOutputHelper
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17048
>                 URL: https://issues.apache.org/jira/browse/HBASE-17048
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17012_3.patch, HBASE-17048.patch, 
> HBASE-17048_1.patch
>
>
> As [~ram_krish] mentioned in HBASE-17021
> https://issues.apache.org/jira/browse/HBASE-17021?focusedCommentId=15646938&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15646938
> The default ByteBuf size is 256B which is too small.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to