[ 
https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695461#comment-15695461
 ] 

Anoop Sam John commented on HBASE-14882:
----------------------------------------

#1  - Oh ya the state var name might have changed over the time.. Ya it is the 
heap requirement for having a long state in KV. ie. seqId..  We called it 
memstoreTS before.
#2 - the former write API is used while copying the cell data over the MSLAB. 
There is no Q we have to avoid writing tags. we must consider tags always.  The 
latter write API used while writing to RPC/HFile.  You know, we have Codecs to 
include tags or not.. So this boolean..  Any way see a TODO there.. We have to 
even avoid this boolean also..  I may start working on that soon.  That is a 
change needed in how we deal with tags serializing over wire.

> Provide a Put API that adds the provided family, qualifier, value without 
> copying
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-14882
>                 URL: https://issues.apache.org/jira/browse/HBASE-14882
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Jerry He
>            Assignee: Xiang Li
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14882.master.000.patch, 
> HBASE-14882.master.001.patch, HBASE-14882.master.002.patch, 
> HBASE-14882.master.003.patch
>
>
> In the Put API, we have addImmutable()
> {code}
>  /**
>    * See {@link #addColumn(byte[], byte[], byte[])}. This version expects
>    * that the underlying arrays won't change. It's intended
>    * for usage internal HBase to and for advanced client applications.
>    */
>   public Put addImmutable(byte [] family, byte [] qualifier, byte [] value)
> {code}
> But in the implementation, the family, qualifier and value are still being 
> copied locally to create kv.
> Hopefully we should provide an API that truly uses immutable family, 
> qualifier and value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to