[
https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721480#comment-15721480
]
Anoop Sam John commented on HBASE-14882:
----------------------------------------
bq.When calculating heapOverhead(), I think I can not make it as a whole
constant value and make
True.. Ya u have fixed part and varying part based on null or not null
bq.In write(OutputStream out, boolean withTags), I return
getSerializedSize(withTags) directly as the number of bytes written. I saw you
calculated len in ValueAndTagRewriteCell' write(), by adding the size together
after each write to output stream.
This way of calling getSerializedSize is just fine.. Ideally both this method
return value and getSerializedSize() return value must match.. So ur way is
also very much fine
This is great patch.. +1
> Provide a Put API that adds the provided family, qualifier, value without
> copying
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14882
> URL: https://issues.apache.org/jira/browse/HBASE-14882
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Jerry He
> Assignee: Xiang Li
> Fix For: 2.0.0
>
> Attachments: HBASE-14882.master.000.patch,
> HBASE-14882.master.001.patch, HBASE-14882.master.002.patch,
> HBASE-14882.master.003.patch, HBASE-14882.master.004.patch,
> HBASE-14882.master.005.patch
>
>
> In the Put API, we have addImmutable()
> {code}
> /**
> * See {@link #addColumn(byte[], byte[], byte[])}. This version expects
> * that the underlying arrays won't change. It's intended
> * for usage internal HBase to and for advanced client applications.
> */
> public Put addImmutable(byte [] family, byte [] qualifier, byte [] value)
> {code}
> But in the implementation, the family, qualifier and value are still being
> copied locally to create kv.
> Hopefully we should provide an API that truly uses immutable family,
> qualifier and value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
