[ 
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701082#comment-15701082
 ] 

Anoop Sam John commented on HBASE-17081:
----------------------------------------

Copying this comment from RB
A new type of Composite ImmutableSegment is created and we use that for the 
snapshot state.. But 80% this new type is not used it as a real Segment type.. 
I mean methods are not implemented but we get the individual segments from the 
composite segment, and act on those.  So my Q is this.. why to have the new 
type.  A List<ImmutableSegment> as snapshot type will work?  Am in favor of 
having new composite type.. That will be cleaner.. But with current way of 
implementation I feel it is not good at all..  In that sense I prefer List way. 
 Am I making my comment clear?



> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
>                 Key: HBASE-17081
>                 URL: https://issues.apache.org/jira/browse/HBASE-17081
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-17081-V01.patch, HBASE-17081-V02.patch, 
> HBASE-17081-V03.patch, Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another 
> part is divided between immutable segments in the compacting pipeline. Upon 
> flush-to-disk request we want to flush all of it to disk, in contrast to 
> flushing only tail of the compacting pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to