[
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705339#comment-15705339
]
Anastasia Braginsky commented on HBASE-17081:
---------------------------------------------
Hey!
I think that with the last patch (V04) there should be no concerns at all.
CompositeImmutableSegment works strictly according to the Composite Design
Pattern. CompositeImmutableSegment lets memstores treat individual immutable
segment and compositions of segments uniformly. The getAllSegments() is used
only in the tests and marked as visible for tests. For me it looks really
smooth :) Please take a look! Let us finish with it, we have many other things
to do here! :)
> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
> Key: HBASE-17081
> URL: https://issues.apache.org/jira/browse/HBASE-17081
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Anastasia Braginsky
> Attachments: HBASE-17081-V01.patch, HBASE-17081-V02.patch,
> HBASE-17081-V03.patch, HBASE-17081-V04.patch,
> Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another
> part is divided between immutable segments in the compacting pipeline. Upon
> flush-to-disk request we want to flush all of it to disk, in contrast to
> flushing only tail of the compacting pipeline.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
