[
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711824#comment-15711824
]
Anastasia Braginsky commented on HBASE-17081:
---------------------------------------------
[~ram_krish], I am copying your concern from the RB here, so we can answer one
another in the real time :)
bq. Ok now i got it. Actually in my opinion you could just call
segment.getScanner only. That is enough.
This is exactly what I am doing. In Line 88, I am calling segment.getScanner on
each segment in the composite segment, then combining a MemStoreScanner from
those scanners.
bq. Once you return MemstoreScanner nothing is going to change and you don't
need this flushingScanner. Pls do consider changing this.
I need flushingScanner in order to close it later. Or do you mean the close()
need to be called anywhere else, but not here?
bq. Also for the actual bug I think you can raise a JIRA to fix it so that we
can unify all. There is no need for getKEyvalueScanner itself and can be
removed. If you are busy let me know I can fix it for you.
I would prefer to leave this JIRA as is (and to commit it asap :) ) and if you
can take it please fix the snapshot scanner count everywhere.
> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
> Key: HBASE-17081
> URL: https://issues.apache.org/jira/browse/HBASE-17081
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Anastasia Braginsky
> Attachments: HBASE-17081-V01.patch, HBASE-17081-V02.patch,
> HBASE-17081-V03.patch, HBASE-17081-V04.patch,
> Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another
> part is divided between immutable segments in the compacting pipeline. Upon
> flush-to-disk request we want to flush all of it to disk, in contrast to
> flushing only tail of the compacting pipeline.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
