[ 
https://issues.apache.org/jira/browse/HBASE-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713345#comment-15713345
 ] 

Enis Soztutar commented on HBASE-15902:
---------------------------------------

The patch looks pretty good. Just some last items: 
In the Scan copy constructors (same thing in assignment), I think we need to do 
a deep-copy of the family vectors. In the Get copy-constructors we do not copy 
the FamilyMap, so we should do that there as well.  
{code}
+  family_map_.insert(scan.family_map_.begin(), scan.family_map_.end());
{code}

This is what the java code does: 
{code}
for (Map.Entry<byte[],NavigableSet<byte[]>> entry : fams.entrySet()) {
      byte [] fam = entry.getKey();
      NavigableSet<byte[]> cols = entry.getValue();
      if (cols != null && cols.size() > 0) {
        for (byte[] col : cols) {
          addColumn(fam, col);
        }
      } else {
        addFamily(fam);
      }
    }
{code}

 - Get has FamilyMap(), HasFamilies(), etc. Let's add those to the Scan as well 
to bring these on-par. 

 - In the cpplint scan (HBASE-17220), one issue that came up was to converting 
all of the usages of {{long}} which is not portable to using fixed-length 
values (int64, etc). But lets leave those as it is for this patch, since we 
will address them in HBASE-17220 patch. 




> Scan Object
> -----------
>
>                 Key: HBASE-15902
>                 URL: https://issues.apache.org/jira/browse/HBASE-15902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-15902.HBASE-14850.patch, 
> HBASE-15902.HBASE-14850.v2.patch, HBASE-15902.HBASE-14850.v3.patch
>
>
> Patch for creating Scan objects. Scan objects thus created can be used by 
> Table implementation to fetch results for a given row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to