[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766066#comment-15766066
]
Jerry He commented on HBASE-16010:
----------------------------------
+1
Some nit.
In HBaseAdmin, two places:
{noformat}
+ executeCallable(new MasterCallable<Void>(getConnection(),
getRpcControllerFactory()) {
+ @Override
+ public Void rpcCall() throws ServiceException {
+ HBaseRpcController controller = rpcControllerFactory.newController();
{noformat}
Use getRpcController() instead of creating a new one.
In MasterRpcServices, two places:
{noformat}
+ for
(org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.ServerName
pbServer : request
{noformat}
Let's use the short name in the code and add to import.
> Put draining function through Admin API
> ---------------------------------------
>
> Key: HBASE-16010
> URL: https://issues.apache.org/jira/browse/HBASE-16010
> Project: HBase
> Issue Type: Improvement
> Reporter: Jerry He
> Assignee: Matt Warhaftig
> Priority: Minor
> Attachments: hbase-16010-v1.patch, hbase-16010-v2.patch
>
>
> Currently, there is no Amdin API for draining function. Client has to
> interact directly with Zookeeper draining node to add and remove draining
> servers.
> For example, in draining_servers.rb:
> {code}
> zkw = org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.new(config,
> "draining_servers", nil)
> parentZnode = zkw.drainingZNode
> begin
> for server in servers
> node = ZKUtil.joinZNode(parentZnode, server)
> ZKUtil.createAndFailSilent(zkw, node)
> end
> ensure
> zkw.close()
> end
> {code}
> This is not good in cases like secure clusters with protected Zookeeper nodes.
> Let's put draining function through Admin API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
