[
https://issues.apache.org/jira/browse/HBASE-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769199#comment-15769199
]
Yu Li commented on HBASE-17345:
-------------------------------
Overall LGTM, some comments:
About {{ConnectionUtils}}:
In {{voidBatch}} and {{voidBatchAll}}, mind explain why {{table.<Object>
batch(actions)}} rather than {{table.<Void> batch(actions)}}?
About {{AsyncTableBase}}:
1. Add javadoc for newly added methods: exists(List)/existsAll,
put(List)/putAll, delete(List)/deleteAll, batch(List)/batchAll?
2. Add more UT cases to cover them?
About {{TestAsyncGetMultiThread}}:
1. Now it's making chaos for each split key, including split-and-compact,
balance and move, and sleep 5 seconds in between each, which will make the test
run for over 2 min. Maybe simplify it a little bit to make the test finish
faster?
2. Also feel the name confusing, maybe TestAsyncGetWithMultiThread is better?
Thanks.
> Implement batch
> ---------------
>
> Key: HBASE-17345
> URL: https://issues.apache.org/jira/browse/HBASE-17345
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17345.patch
>
>
> Add the support for general batch based on the code introduced in HBASE-17142.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
