[
https://issues.apache.org/jira/browse/HBASE-17345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771587#comment-15771587
]
Duo Zhang commented on HBASE-17345:
-----------------------------------
{quote}
About ConnectionUtils:
In voidBatch and voidBatchAll, mind explain why table.<Object> batch(actions)
rather than table.<Void> batch(actions)?
{quote}
We do not care about the return value of put or delete, but I'm sure that we do
have a return value for these operations and it is not Void... So a safe way is
to keep it as Object and map it to ''null'. 'null' can be any type so it is
safe to cast it to Void.
{quote}
About AsyncTableBase:
1. Add javadoc for newly added methods: exists(List)/existsAll,
put(List)/putAll, delete(List)/deleteAll, batch(List)/batchAll?
2. Add more UT cases to cover them?
{quote}
Done.
{quote}
About TestAsyncGetMultiThread:
1. Now it's making chaos for each split key, including split-and-compact,
balance and move, and sleep 5 seconds in between each, which will make the test
run for over 2 min. Maybe simplify it a little bit to make the test finish
faster?
2. Also feel the name confusing, maybe TestAsyncGetWithMultiThread is better?
{quote}
I've renamed it to TestAsyncTableGetMultiThreaded. And it is designed to test
the failover of our async client implementation stack, so I think it is
reasonable to keep it running for a while?
> Implement batch
> ---------------
>
> Key: HBASE-17345
> URL: https://issues.apache.org/jira/browse/HBASE-17345
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17345-v1.patch, HBASE-17345-v2.patch,
> HBASE-17345-v3.patch, HBASE-17345.patch
>
>
> Add the support for general batch based on the code introduced in HBASE-17142.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
