[
https://issues.apache.org/jira/browse/HBASE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769280#comment-15769280
]
Phil Yang commented on HBASE-17314:
-----------------------------------
Thank you. The reason is after HBASE-11392 adding peer is through master so we
must start a cluster first then add a peer. Before this it is ok to add peer
first because it only add a znode on ZK.
{code}
@@ -94,12 +94,13 @@ public class TestGlobalThrottler {
ReplicationAdmin admin1 = new ReplicationAdmin(conf1);
ReplicationPeerConfig rpc = new ReplicationPeerConfig();
rpc.setClusterKey(utility2.getClusterKey());
- admin1.addPeer("peer1", rpc, null);
- admin1.addPeer("peer2", rpc, null);
- admin1.addPeer("peer3", rpc, null);
utility1.startMiniCluster(1, 1);
utility2.startMiniCluster(1, 1);
+
+ admin1.addPeer("peer1", rpc, null);
+ admin1.addPeer("peer2", rpc, null);
+ admin1.addPeer("peer3", rpc, null);
}
{code}
Will upload a new patch with your suggests. Thanks.
> Limit total buffered size for all replication sources
> -----------------------------------------------------
>
> Key: HBASE-17314
> URL: https://issues.apache.org/jira/browse/HBASE-17314
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Reporter: Phil Yang
> Assignee: Phil Yang
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17314.branch-1.v01.patch, HBASE-17314.v01.patch,
> HBASE-17314.v02.patch, HBASE-17314.v03.patch, HBASE-17314.v04.patch
>
>
> If we have many peers or some servers have many recovered queues, we will
> hold many entries in memory which will increase the pressure of GC, even
> maybe OOM because we will read entries for 64MB to buffer in default for one
> source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
