[ 
https://issues.apache.org/jira/browse/HBASE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769305#comment-15769305
 ] 

Phil Yang commented on HBASE-17314:
-----------------------------------

{quote}
This looks like it could be package private rather than public:
2344    public ReplicationSourceService getReplicationSourceService() {
{quote}

It is used in 
org.apache.hadoop.hbase.replication.regionserver.TestGlobalThrottler so it can 
only be public.

> Limit total buffered size for all replication sources
> -----------------------------------------------------
>
>                 Key: HBASE-17314
>                 URL: https://issues.apache.org/jira/browse/HBASE-17314
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17314.branch-1.v01.patch, HBASE-17314.v01.patch, 
> HBASE-17314.v02.patch, HBASE-17314.v03.patch, HBASE-17314.v04.patch
>
>
> If we have many peers or some servers have many recovered queues, we will 
> hold many entries in memory which will increase the pressure of GC, even 
> maybe OOM because we will read entries for 64MB to buffer in default for one 
> source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to