[ https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783945#comment-15783945 ]
stack commented on HBASE-17372: ------------------------------- Looking at patch, I like the aggregating of all the timeout into a single class. It is a very nice improvement/cleanup. I like the [~yangzhe1991] suggestion of operationconfig rather than retryconfig so could add in to it other per-request-configs... (as you suggest above ...non-timeout related config): private final RetryConfig retryConfig; This is very nice. > Make AsyncTable thread safe > --------------------------- > > Key: HBASE-17372 > URL: https://issues.apache.org/jira/browse/HBASE-17372 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17372-v1.patch, HBASE-17372.patch > > > The most methods are already thread safe. The problem is that we have some > methods that used to set timeout, we need to remove these methods and add a > parameter for each call to specific timeout settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)