[ 
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785673#comment-15785673
 ] 

stack commented on HBASE-17372:
-------------------------------

Yeah, after making the comment I remembered that it will be part of the public 
API. So, I think it should have a more generic name than RetryConfig so we are 
open to future amendment.


bq. As said above, it seems a little confusing that we to need pass a config 
that contains a 'writeRpcTimeout' when calling get, and vise versa. And if we 
decide to only have one 'rpcTimeout' field in RetryConfig, do we still need the 
separated readRpcTimeout and writeRpcTimeout config? If still needed, then do 
we need to add more xxxRpcTimeout configs such as appendRpcTimeout?

Agree.

No to a timeout per operation type.  Should be one rpc timeout only.  When a 
batch of heterogeneous ops, then what to set for a timeout will be unavoidably 
coarse.



> Make AsyncTable thread safe
> ---------------------------
>
>                 Key: HBASE-17372
>                 URL: https://issues.apache.org/jira/browse/HBASE-17372
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17372-v1.patch, HBASE-17372.patch
>
>
> The most methods are already thread safe. The problem is that we have some 
> methods that used to set timeout, we need to remove these methods and add a 
> parameter for each call to specific timeout settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to