[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801798#comment-15801798
]
Ted Yu commented on HBASE-17408:
--------------------------------
Thanks for taking this JIRA.
{code}
+ if (this.maxRowsPerRequest <= 0) {
+ throw new IllegalArgumentException("maxRowsPerRequest="
{code}
Please move the above check immediately below where this.maxRowsPerRequest is
assigned.
{code}
+ public void notifyFinal(ReturnCode code, HRegionLocation loc, long
rowSize) {
+ if (code == ReturnCode.INCLUDE) {
+ long currentRows = serverRows.containsKey(loc.getServerName())
+ ? serverRows.get(loc.getServerName()) : 0L;
+ serverRows.put(loc.getServerName(), currentRows + 1);
{code}
Why is 1 used in the last line above ? rowSize has no effect ?
> Introduce per request limit by number of mutations
> --------------------------------------------------
>
> Key: HBASE-17408
> URL: https://issues.apache.org/jira/browse/HBASE-17408
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Ted Yu
> Assignee: ChiaPing Tsai
> Fix For: 2.0.0
>
> Attachments: HBASE-17408.v0.patch, HBASE-17408.v1.patch
>
>
> HBASE-16224 introduced hbase.client.max.perrequest.heapsize to limit the
> amount of data sent from client.
> We should consider adding per request limit through the number of mutations
> in a batch.
> In recent troubleshooting sessions, customer had to do this in their
> application code to avoid OOME on the server side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
