[ 
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801844#comment-15801844
 ] 

ChiaPing Tsai commented on HBASE-17408:
---------------------------------------

bq. Please move the above check immediately below where this.maxRowsPerRequest 
is assigned.
copy that.

bq. Why is 1 used in the last line above ?
It means that an extra row is accepted, so we increment the row count by one.

bq. rowSize has no effect ?
Yes, RequestRowsChecker only consider the number of rows. The heap size of row 
(rowSize) is useless for RequestRowsChecker.

> Introduce per request limit by number of mutations
> --------------------------------------------------
>
>                 Key: HBASE-17408
>                 URL: https://issues.apache.org/jira/browse/HBASE-17408
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Ted Yu
>            Assignee: ChiaPing Tsai
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17408.v0.patch, HBASE-17408.v1.patch
>
>
> HBASE-16224 introduced hbase.client.max.perrequest.heapsize to limit the 
> amount of data sent from client.
> We should consider adding per request limit through the number of mutations 
> in a batch.
> In recent troubleshooting sessions, customer had to do this in their 
> application code to avoid OOME on the server side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to