[
https://issues.apache.org/jira/browse/HBASE-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171460#comment-13171460
]
stack commented on HBASE-5058:
------------------------------
Is this check too generic:
{code}
+ } catch (UndeclaredThrowableException ute) {
{code}
For sure if above, you can deduce:
{code}
+ // RPC connection to the master is dead, try again
{code}
Will this change behavior? Or is it that what we have here is dumb?
{code}
} catch (MasterNotRunningException mnre) {
- HConnectionManager.deleteStaleConnection(this.connection);
- this.connection = HConnectionManager.getConnection(this.conf);
- } catch (UndeclaredThrowableException ute) {
- HConnectionManager.deleteStaleConnection(this.connection);
- this.connection = HConnectionManager.getConnection(this.conf);
+ // ignore and try again
{code}
If making new patch, fix this javadoc... missing 'in'
{code}
+ * The HConnection can be re-used again another attempt.
{code}
Otherwise, looks good.
> Allow HBaseAmin to use an existing connection
> ---------------------------------------------
>
> Key: HBASE-5058
> URL: https://issues.apache.org/jira/browse/HBASE-5058
> Project: HBase
> Issue Type: Sub-task
> Components: client
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5058.txt
>
>
> What HBASE-4805 does for HTables, this should do for HBaseAdmin.
> Along with this the shared error handling and retrying between HBaseAdmin and
> HConnectionManager can also be improved. I'll attach a first pass patch soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
