[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821693#comment-15821693
]
Yu Li commented on HBASE-17372:
-------------------------------
Thanks for the ping [~Apache9], and yes, I like the new patch, it follows a
similar way with existing stable releases.
One minor comment on codes, that I find several places with "import .*" like
below lines, which should be changed to explicit imports.
{code}
import static java.util.stream.Collectors.*;
import static org.apache.hadoop.hbase.client.ConnectionUtils.*;
{code}
And one thing to confirm, that it seems {{AsyncTableBuilderBase}} is not thread
safe, right? Do we need to add some javadoc on the class to make this clear?
All other parts LGTM, thanks.
> Make AsyncTable thread safe
> ---------------------------
>
> Key: HBASE-17372
> URL: https://issues.apache.org/jira/browse/HBASE-17372
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17372.patch, HBASE-17372-v1.patch,
> HBASE-17372-v2.patch, HBASE-17372-v3.patch, HBASE-17372-v4.patch,
> HBASE-17372-v5.patch, HBASE-17372-v6.patch
>
>
> The most methods are already thread safe. The problem is that we have some
> methods that used to set timeout, we need to remove these methods and add a
> parameter for each call to specific timeout settings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
