[
https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831434#comment-15831434
]
Yu Li commented on HBASE-17491:
-------------------------------
Thanks for the review [~tedyu] [~Apache9] and [~stack].
bq. Remove this on commit
Sure, will do.
bq. you pass a TableBuilderImpl to the HTable constructor rather than the
Interface...I suppose having the talbename in the builder makes it so you can
set different op timeouts dependent on if it a system table or not
Correct, and this simply follows the way of {{AsyncTableBuilderBase}} and
constructor of {{RawAsyncTableImpl}}. Although a little bit unusual to use a
builder as a holder to pass configurations, I think it's better than passing
each configuration as a parameter in the constructor as {{HFileContextBuilder}}
does.
bq. How do I get a TableBuilder?
Oh yes, this is something missing, will add a {{getTableBuilder}} interface in
{{Connection}} in the next patch.
> Remove all setters from HTable interface and introduce a TableBuilder to
> build Table instance
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-17491
> URL: https://issues.apache.org/jira/browse/HBASE-17491
> Project: HBase
> Issue Type: Sub-task
> Reporter: Yu Li
> Assignee: Yu Li
> Attachments: HBASE-17491.patch, HBASE-17491.v2.patch,
> HBASE-17491.v3.patch
>
>
> As titled, we will remove all setters in HTable for master branch and
> deprecate them for branch-1 to make HTable thread-safe. And a new
> {{TableBuilder}} interface will be introduced to build Table instance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
