[
https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832116#comment-15832116
]
stack commented on HBASE-17491:
-------------------------------
Just seems odd making an Interface and not using it. This is nit stuff given
this is all internal. What if you added a getter on the Builder Interface for
tableName? That would 'force' implementations to pass TableName on
construction. Then you'd have a getter to pull on inside in the HTable
constructor...
If you passed the tablename separate from the builder (as it is now) would that
help?
v4 still has
2856 // trivial change to trigger UT TODO remove me
2857 LOG.trace("HRegionServer#main");
There is still a getTable in the Connection Implementation?
Patch looks great otherwise. Thanks [~carp84]
> Remove all setters from HTable interface and introduce a TableBuilder to
> build Table instance
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-17491
> URL: https://issues.apache.org/jira/browse/HBASE-17491
> Project: HBase
> Issue Type: Sub-task
> Reporter: Yu Li
> Assignee: Yu Li
> Attachments: HBASE-17491.patch, HBASE-17491.v2.patch,
> HBASE-17491.v3.patch, HBASE-17491.v4.patch
>
>
> As titled, we will remove all setters in HTable for master branch and
> deprecate them for branch-1 to make HTable thread-safe. And a new
> {{TableBuilder}} interface will be introduced to build Table instance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
