[
https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172175#comment-13172175
]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507880/5051.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/543//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/543//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/543//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each
> call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch,
> 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to
> imply that it's an instance managed by HBaseTestingUtility, most of the users
> don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira