[ 
https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172263#comment-13172263
 ] 

nkeywal commented on HBASE-5051:
--------------------------------

TestMasterReplication hang; but it hang on trunk as well (see: 
https://builds.apache.org/job/HBase-TRUNK/2558/console)
TestReplication: usually flaky.

I think the patch is ok.

                
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each 
> call
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5051
>                 URL: https://issues.apache.org/jira/browse/HBASE-5051
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.94.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 
> 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to 
> imply that it's an instance managed by HBaseTestingUtility, most of the users 
> don't close it => leak

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to