[ 
https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839137#comment-15839137
 ] 

Jingcheng Du commented on HBASE-16812:
--------------------------------------

Thanks Mr. [[email protected]].
bq. How would you summarize the behavioral change in how MOB works after this 
patch goes in? 
Sure, I will do.

bq. MOB hfiles have few entries in them?
You are right, the number of the delete markers should be small.
As you know, now the delete markers are retained in hbase major compaction 
until they are expired, and the delete markers are written to mob files again 
and again in major compaction. This tag is used to mark if a delete marker had 
been flushed to mob files and is not flushed to mob files any more.

I am thinking of using the existing ref tag for the delete markers instead of 
the new tag type. How do you think about this? Thanks.

bq. If a delete marker has this tag, it is not flushed to a mob file in major 
compaction." Looking at code, it 'is' flushed?
It should be "is not".
{code}writer.append(c);{code} writes the delete marker to a store file in hbase.
{code}delFileWriter.append(c){code} writes the delete marker to a mob del file.
So if a delete marker has this tag, it doesn't need the code 
{code}delFileWriter.append(c){code}.


> Clean up the locks in MOB
> -------------------------
>
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Jingcheng Du
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch, HBASE-16812.patch
>
>
> Clean up the locks in MOB. 
> # Retain all the delete markers in mob-enabled columns until they are expired.
> # Remove the locks from major compaction of mob-enabled columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to