[
https://issues.apache.org/jira/browse/HBASE-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857253#comment-15857253
]
Enis Soztutar commented on HBASE-14123:
---------------------------------------
bq. This JIRA: https://issues.apache.org/jira/browse/HBASE-16825 Contains 2
follow up sub tasks and 3 related JIRAs.
This came up before, but still the way that this effort is tracked is not
correct.
There are a couple of things that we are not following in the "standard way".
This is important because otherwise reviewers like me cannot figure out what is
committed and where, and what is to follow once the merge is complete.
First, when an issue is resolved with a fixVersion set, it means that the patch
itself is available in the branch that will be released as that version.
Looking at all 9 subtasks of HBASE-16825, they are marked as fixed with
fixVersion 2.0.0. This is wrong, since they are not committed in the master
code (or anywhere for that matter).
If an issue is committed to a branch, it should be resolved with a fixVersion
equal to the branch name. Once the branch is merged, then we have the option to
add fixVersions.
Second, when doing patch iterations, we do not track "addressing comments" with
individual jiras. In that sense, the first 9 subtasks of HBASE-HBASE-16825
seems completely unnecessary. You should open a jira only in cases where the
comments are not addressed, and we need a jira for tracking those changes
afterwards.
Third, looking at the Phase 3 jiras, bunch of them are in fixed state, again
with fixVersion of 2.0.0. Are any of these jiras committed anywhere? Some of
them I can find it in the branch. [~ted_yu] why are these jiras marked with
2.0.0?
Can you guys please mark all the jiras in the branch with the
fixVersion=HBASE-7912 (and not 2.0.0). Once the merge, we can correct the
fixVersions.
Where is the jira for moving to the backup module?
Can you please check or comment on the findbugs warnings and test failures.
Also please do the write up (that I asked above) for the other reviewers.
> HBase Backup/Restore Phase 2
> ----------------------------
>
> Key: HBASE-14123
> URL: https://issues.apache.org/jira/browse/HBASE-14123
> Project: HBase
> Issue Type: Umbrella
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 14123-master.v14.txt, 14123-master.v15.txt,
> 14123-master.v16.txt, 14123-master.v17.txt, 14123-master.v18.txt,
> 14123-master.v19.txt, 14123-master.v20.txt, 14123-master.v21.txt,
> 14123-master.v24.txt, 14123-master.v25.txt, 14123-master.v27.txt,
> 14123-master.v28.txt, 14123-master.v29.full.txt, 14123-master.v2.txt,
> 14123-master.v30.txt, 14123-master.v31.txt, 14123-master.v32.txt,
> 14123-master.v33.txt, 14123-master.v34.txt, 14123-master.v35.txt,
> 14123-master.v36.txt, 14123-master.v37.txt, 14123-master.v38.txt,
> 14123.master.v39.patch, 14123-master.v3.txt, 14123.master.v40.patch,
> 14123.master.v41.patch, 14123.master.v42.patch, 14123.master.v44.patch,
> 14123.master.v45.patch, 14123.master.v46.patch, 14123.master.v48.patch,
> 14123.master.v49.patch, 14123.master.v50.patch, 14123.master.v51.patch,
> 14123.master.v52.patch, 14123.master.v54.patch, 14123.master.v56.patch,
> 14123.master.v57.patch, 14123-master.v5.txt, 14123-master.v6.txt,
> 14123-master.v7.txt, 14123-master.v8.txt, 14123-master.v9.txt, 14123-v14.txt,
> HBASE-14123-for-7912-v1.patch, HBASE-14123-for-7912-v6.patch,
> HBASE-14123-v10.patch, HBASE-14123-v11.patch, HBASE-14123-v12.patch,
> HBASE-14123-v13.patch, HBASE-14123-v15.patch, HBASE-14123-v16.patch,
> HBASE-14123-v1.patch, HBASE-14123-v2.patch, HBASE-14123-v3.patch,
> HBASE-14123-v4.patch, HBASE-14123-v5.patch, HBASE-14123-v6.patch,
> HBASE-14123-v7.patch, HBASE-14123-v9.patch
>
>
> Phase 2 umbrella JIRA. See HBASE-7912 for design document and description.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
