[
https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173890#comment-13173890
]
jirapos...@reviews.apache.org commented on HBASE-5070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3273/#review4034
-----------------------------------------------------------
Ship it!
This patch should go in. Good improvements. Doesn't address the bigger issues
of Configuration inline w/ HTD -- have you tried it, I mean, IIRC, though you
might have one custom config only, the whole Configuration will be output per
Constraint? -- and adding support to shell. Those are in different issues?
src/docbkx/book.xml
<https://reviews.apache.org/r/3273/#comment9139>
Only thing missing is "since 0.94" which is when constraints will show up.
src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java
<https://reviews.apache.org/r/3273/#comment9140>
Better
- Michael
On 2011-12-20 19:14:46, Jesse Yates wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3273/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-20 19:14:46)
bq.
bq.
bq. Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Follow-up on changes to constraint as per stack's comments on HBASE-4605.
bq.
bq.
bq. This addresses bug HBASE-5070.
bq. https://issues.apache.org/jira/browse/HBASE-5070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/docbkx/book.xml bd3f881
bq. src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java
7ce6d45
bq. src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7
bq. src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
7825466
bq. src/main/java/org/apache/hadoop/hbase/constraint/package-info.java
6145ed5
bq.
src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
c49098d
bq.
bq. Diff: https://reviews.apache.org/r/3273/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn clean test -P localTests -Dest=*Constraint* <- all tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Jesse
bq.
bq.
> Constraints implementation and javadoc changes
> ----------------------------------------------
>
> Key: HBASE-5070
> URL: https://issues.apache.org/jira/browse/HBASE-5070
> Project: HBase
> Issue Type: Task
> Reporter: Zhihong Yu
>
> This is continuation of HBASE-4605
> See Stack's comments https://reviews.apache.org/r/2579/#review3980
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
