[
https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175016#comment-13175016
]
jirapos...@reviews.apache.org commented on HBASE-5070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3273/
-----------------------------------------------------------
(Updated 2011-12-22 19:59:47.762581)
Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack.
Changes
-------
Fixing documentation as per comments.
Remaining concerns:
1) handling configuration storage in HTD (seems ok, but see comments on stack's
comments on previous patch)
2) Configured has a default constructor which does setConf(null). Do we want to
enforce this behavior? Or just let it be null? Or create our own BaseConfigured
class that extends from Configurable?
Summary
-------
Follow-up on changes to constraint as per stack's comments on HBASE-4605.
This addresses bug HBASE-5070.
https://issues.apache.org/jira/browse/HBASE-5070
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45
src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7
src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466
src/docbkx/book.xml bd3f881
src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5
src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
c49098d
Diff: https://reviews.apache.org/r/3273/diff
Testing
-------
mvn clean test -P localTests -Dest=*Constraint* <- all tests pass.
Thanks,
Jesse
> Constraints implementation and javadoc changes
> ----------------------------------------------
>
> Key: HBASE-5070
> URL: https://issues.apache.org/jira/browse/HBASE-5070
> Project: HBase
> Issue Type: Task
> Reporter: Zhihong Yu
>
> This is continuation of HBASE-4605
> See Stack's comments https://reviews.apache.org/r/2579/#review3980
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
