[
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898233#comment-15898233
]
Enis Soztutar commented on HBASE-17680:
---------------------------------------
Thanks Ted for the changes.
- Please remove ALL commented out code. This is the third time for the same
comment.
{code}
+ //hbase::Configuration conf;
+ // hbase::TestUtil *test_util = new hbase::TestUtil(2,
ClientTest::kDefHBaseConfPath.c_str());
{code}
- Refactor {{addColMid_}} -> {{add_col_mid_}}. and {{setConfMid_}}.
- These methods should take {{const std::string&}} instead of {{char *}}.
{code}
{{void WriteConf(jobject conf, const char *filepath);}}
+jbyteArray MiniCluster::StrToByteChar(const char *str) {
+TestUtil::TestUtil(int servers, const char *confPath)
{code}
- Remove:
{code}
+ LOG(INFO) << "retrieving " << key;
+ LOG(INFO) << "Got string " << val;
{code}
and maybe:
{code}
+ LOG(INFO) << "retrieved port " << port;
{code}
- Change these to check for NULL instead:
{code}
if (put == 0) {
+ if (mid == 0) {
+ if (n == 0) return NULL;
{code}
- I'll do the changes for client-test for not depending on the WriteConf() as a
follow up.
> Run mini cluster through JNI in tests
> -------------------------------------
>
> Key: HBASE-17680
> URL: https://issues.apache.org/jira/browse/HBASE-17680
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 17680.v14.txt, 17680.v17.txt, 17680.v18.txt,
> 17680.v1.txt, 17680.v20.txt, 17680.v22.txt, 17680.v23.txt, 17680.v26.txt,
> 17680.v27.txt, 17680.v28.txt, 17680.v29.txt, 17680.v30.txt, 17680.v31.txt,
> 17680.v3.txt, 17680.v8.txt
>
>
> Currently tests start local hbase cluster through hbase shell.
> There is less control over the configuration of the local cluster this way.
> This issue would replace hbase shell with JNI interface to mini cluster.
> We would have full control over the cluster behavior.
> Thanks to [~devaraj] who started this initiative.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
