[
https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899727#comment-15899727
]
Anastasia Braginsky commented on HBASE-16438:
---------------------------------------------
Hey [~ram_krish], thank you very much for the second patch!
The second one looks much better than the first patch, but still we have some
comments. I don't want to discuss the comments here, as they are all written in
the RB, and we are waiting for your answers :)
Generally, the following naturally appears to me from what I have seen:
1. In this patch you have coverage for the following problems:
a. Create a cell type so that chunk id is embedded (HBASE-16438)
b. Inserting CellChunkMap from the old patch (HBASE-16436)
c. Adding the single entity for allocating/de-allocating the chunks and
keeping a mapping chunkID->chunk (HBASE-17377)
2. The patch is good, but we have some comments about the implementation and
some suggestions about the design. We can discuss it all. I believe that you
can continue with this patch till testing and committing and we can support you
with reviews. What do you think? If you agree, then HBASE-16436 and HBASE-17377
can be cancelled.
3. Once you commit we can continue with integration into CompactingMemStore,
variable size chunks, irregular cells, etc.
I really would like to hear your opinion! :)
What do you think?
> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>
> Key: HBASE-16438
> URL: https://issues.apache.org/jira/browse/HBASE-16438
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: MemstoreChunkCell_memstoreChunkCreator_oldversion.patch,
> MemstoreChunkCell_trunk.patch
>
>
> For CellChunkMap we may need a cell such that the chunk out of which it was
> created, the id of the chunk be embedded in it so that when doing flattening
> we can use the chunk id as a meta data. More details will follow once the
> initial tasks are completed.
> Why we need to embed the chunkid in the Cell is described by [~anastas] in
> this remark over in parent issue
> https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
