[
https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923762#comment-15923762
]
ramkrishna.s.vasudevan commented on HBASE-16438:
------------------------------------------------
bq.I also don't understand why MemStoreLABChunkCreator works only with chunks
allocated from pool. Please decouple the ChunkPool and the ChunkCreator, there
can be chunks without pool,
We have decoupled. Now whenever there is MSLAB we will use the chunkCreator
only.
Am just seeing this comment from you so little late in replying.
Also the chunkCreator is the one doing the chunkCreation with or without pool.
That is sure. Initially i was thinking whether it is good to go only with MSLAB
but no pool atleast for offheap case. That was the intent initially but now in
latest patch everything goes through chunkCreator only. But MSPool will have a
chunkCreator and the same chunkCreator will be in MSLAB also. I think that is
the easiest and cleaner way to do rather than wrapping Pool inside ChunkCreator.
> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>
> Key: HBASE-16438
> URL: https://issues.apache.org/jira/browse/HBASE-16438
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-16438.patch,
> MemstoreChunkCell_memstoreChunkCreator_oldversion.patch,
> MemstoreChunkCell_trunk.patch
>
>
> For CellChunkMap we may need a cell such that the chunk out of which it was
> created, the id of the chunk be embedded in it so that when doing flattening
> we can use the chunk id as a meta data. More details will follow once the
> initial tasks are completed.
> Why we need to embed the chunkid in the Cell is described by [~anastas] in
> this remark over in parent issue
> https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
