[
https://issues.apache.org/jira/browse/HBASE-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906112#comment-15906112
]
Tianying Chang commented on HBASE-17453:
----------------------------------------
[~ted_yu] It seems for generating the patch for master 2.0 version, I also
need to add the new API into
"hbase-protocol-shaded/src/main/protobuf/Client.proto" besides just
"hbase-protocol/src/main/protobuf/Client.proto" as I did for 1.2.5. ?
I made same change to "hbase-protocol-shaded/src/main/protobuf/Client.proto",
but when generating the ClientProtos.java file, they have differences other
than my change, e.g. "return Consistency.forNumber(number);" vs "return
Consistency.valueOf(number); I am wondering what version of protoc is HBase
master using?
> add Ping into HBase server for deprecated GetProtocolVersion
> ------------------------------------------------------------
>
> Key: HBASE-17453
> URL: https://issues.apache.org/jira/browse/HBASE-17453
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 1.2.2
> Reporter: Tianying Chang
> Assignee: Tianying Chang
> Priority: Minor
> Attachments: HBASE-17453-1.2.patch, HBASE-17453-master.patch
>
>
> Our HBase service is hosted in AWS. We saw cases where the connection between
> the client (Asynchbase in our case) and server stop working but did not throw
> any exception, therefore traffic stuck. So we added a "Ping" feature in
> AsyncHBase 1.5 by utilizing the GetProtocolVersion() API provided at RS side,
> if no traffic for given time, we send the "Ping", if no response back for
> "Ping", we assume the connect is bad and reconnect.
> Now we are upgrading cluster from 94 to 1.2. However, GetProtocolVersion() is
> deprecated. To be able to support same detect/reconnect feature, we added
> Ping() in our internal HBase 1.2 branch, and also patched accordingly in
> Asynchbase 1.7.
> We would like to open source this feature since it is useful for use case in
> AWS environment.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
