[
https://issues.apache.org/jira/browse/HBASE-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924742#comment-15924742
]
Anoop Sam John commented on HBASE-17453:
----------------------------------------
Seems no change required in MasterProtos.java. Pls avoid that from the patch.
Ted also asked
{code}
message PingRequest {
503 optional bool processed = 1;
504 }
{code}
Why we need an optional boolean param in request. No need of any params IMO.
In PingResponse also better the 'processed' param can be a required one. Any
way this will be true if u get a response. Or else , when connection issue,
there will be no response at all.
Else things looks simple and good.
> add Ping into HBase server for deprecated GetProtocolVersion
> ------------------------------------------------------------
>
> Key: HBASE-17453
> URL: https://issues.apache.org/jira/browse/HBASE-17453
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 1.2.2
> Reporter: Tianying Chang
> Assignee: Tianying Chang
> Priority: Minor
> Fix For: 2.0.0, 1.2.5
>
> Attachments: HBASE-17453-1.2.patch, HBASE-17453-master.patch,
> HBASE-17453-master-v1.patch
>
>
> Our HBase service is hosted in AWS. We saw cases where the connection between
> the client (Asynchbase in our case) and server stop working but did not throw
> any exception, therefore traffic stuck. So we added a "Ping" feature in
> AsyncHBase 1.5 by utilizing the GetProtocolVersion() API provided at RS side,
> if no traffic for given time, we send the "Ping", if no response back for
> "Ping", we assume the connect is bad and reconnect.
> Now we are upgrading cluster from 94 to 1.2. However, GetProtocolVersion() is
> deprecated. To be able to support same detect/reconnect feature, we added
> Ping() in our internal HBase 1.2 branch, and also patched accordingly in
> Asynchbase 1.7.
> We would like to open source this feature since it is useful for use case in
> AWS environment.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
