[
https://issues.apache.org/jira/browse/HBASE-17754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925165#comment-15925165
]
Xiaobing Zhou commented on HBASE-17754:
---------------------------------------
Thanks [~enis] for the work. Some of my comments:
# there are a couple of compile errors
# retry-test shouldn't be removed.
# AsyncConnectionImpl::region_locator returns wrong date type, i.e.
std::shared_ptr<LocationCache>
# RawAsyncTable::Get is too complex, should be simplified to have Result only
# change RawAsyncTable::CreateCaller to RawAsyncTable::CreateCallerBuilder to
be self-descriptive.
# In RawAsyncTable::Get,
{noformat}
CreateCaller<std::shared_ptr<Result>>(get.Row(),
connection_conf_->read_rpc_timeout())
{noformat}
should be
{noformat}
CreateCaller<SingleRequestCallerBuilder<Result>>(get.Row(),
connection_conf_->read_rpc_timeout())
{noformat}
> [C++] RawAsyncTable
> -------------------
>
> Key: HBASE-17754
> URL: https://issues.apache.org/jira/browse/HBASE-17754
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hbase-17754_v0.patch, hbase-17754_v1.patch
>
>
> We need RawAsyncTable to connect {{table.h}} to the async retrying callers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
