[
https://issues.apache.org/jira/browse/HBASE-17754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925251#comment-15925251
]
Enis Soztutar commented on HBASE-17754:
---------------------------------------
bq. there are a couple of compile errors
Should not be, but let me test.
bq. retry-test shouldn't be removed.
The reason I've removed that is that existing test client-test, now covers the
testing of the retrying code path without mocking. Let me check whether we can
keep it.
Thanks for the review.
bq. RawAsyncTable::Get is too complex, should be simplified to have Result only
You mean return {{Result}} or return {{Future<Result>}}? RawAsyncTable is an
async class, so it should return a Future, as opposed to returning by value.
table.h returns the non-future.
I am returning a shared_ptr<Result> as opposed to Result to avoid the copying
of Result object. Result is pretty heavy-weight to copy around.
bq. 6. In RawAsyncTable::Get,
This is the template:
{code}
template <typename RESP>
std::shared_ptr<SingleRequestCallerBuilder<RESP>>
RawAsyncTable::CreateCallerBuilder
{code},
so when calling like:
{code}
CreateCaller<std::shared_ptr<Result>>(get.Row(),
connection_conf_->read_rpc_timeout())
{code}
aren't we instantiating the above with {{RESP = std::shared_ptr<Result>}}? And
the compilation works this way.
> [C++] RawAsyncTable
> -------------------
>
> Key: HBASE-17754
> URL: https://issues.apache.org/jira/browse/HBASE-17754
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: hbase-17754_v0.patch, hbase-17754_v1.patch
>
>
> We need RawAsyncTable to connect {{table.h}} to the async retrying callers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
