[
https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927523#comment-15927523
]
stack commented on HBASE-16438:
-------------------------------
I took a quick look at the patch.
ByteBufferChunkCell should be in hbase-server beside the MSLAB rather than out
in hbase-common? It is a server-side only thing? Ditto with copyToChunkCell and
ChunkCell? What you think?
NoTagByteBufferChunkCell <= You know what I'm going to say (smile).
Should this be final:
private long id = -1;
It is passed on Construction. Can it change during lifetime of the Cell?
Is it an 'id' or is it an 'offset'?
Can we pass in the id when we init a chunk?
Will it ever be the case that Cells from Chunks are persisted across restarts?
Say, in a bucketcache that is persisted? Just wondering if the chunkid needs to
be unique across restarts?
What is the nomenclature here?
We have MSLABChunkCreator. So a Chunk is a 'piece' of a MSLAB? And a
'MSLABChunkCreateor' creates chunks or allocates pieces of the MSLAB? Do we
have to have MSLAB in the name? Is it MSLAB only?
We keep a chunkIdMap? Is this of all chunks? How many chunks will there be? All
threads will be banging on this Map?
Regards the below, who sets forceOnHeapOnly? Rather should we pass in the Cell
and let the allocator figure where to allocate the memory?
Chunk createChunk(boolean forceOnheapOnly) {
So if no chunk pool, we keep chunk ids in a map elsewhere than in
MSLABChunkCreateor? Should we do this accounting in one place only?
Otherwise, looking good.
> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>
> Key: HBASE-16438
> URL: https://issues.apache.org/jira/browse/HBASE-16438
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-16438_1.patch, HBASE-16438.patch,
> MemstoreChunkCell_memstoreChunkCreator_oldversion.patch,
> MemstoreChunkCell_trunk.patch
>
>
> For CellChunkMap we may need a cell such that the chunk out of which it was
> created, the id of the chunk be embedded in it so that when doing flattening
> we can use the chunk id as a meta data. More details will follow once the
> initial tasks are completed.
> Why we need to embed the chunkid in the Cell is described by [~anastas] in
> this remark over in parent issue
> https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
