[ 
https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925863#comment-15925863
 ] 

ramkrishna.s.vasudevan commented on HBASE-16438:
------------------------------------------------

The cyclic reference is with the current code where if we use chunkCreator in 
MSLAB and wrap the pool inside chunkCreator. But i think that can be managed if 
we allow the pool itself to reside inside the ChunkCreator and the HRS also 
will only instantiate the ChunkCreator and internally the chunkCreator creates 
and manages the pool.
For the 2nd one, if we make the CAS inside chunkCreator then all the MSLAB 
should wait for getting a successful chunk. Where is now it is within one MSLAB 
there is a fight. So with in a MSLAB we get a chunk and two threads compete to 
make it as the curChunk.
If we move it to chunkCreator two different threads on two different MSLAB 
itself need to wait for one to get the chunk and then create for other one. Am 
saying for the non-pooled cases.

> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>
>                 Key: HBASE-16438
>                 URL: https://issues.apache.org/jira/browse/HBASE-16438
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-16438_1.patch, HBASE-16438.patch, 
> MemstoreChunkCell_memstoreChunkCreator_oldversion.patch, 
> MemstoreChunkCell_trunk.patch
>
>
> For CellChunkMap we may need a cell such that the chunk out of which it was 
> created, the id of the chunk be embedded in it so that when doing flattening 
> we can use the chunk id as a meta data. More details will follow once the 
> initial tasks are completed. 
> Why we need to embed the chunkid in the Cell is described by [~anastas] in 
> this remark over in parent issue 
> https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to