[ 
https://issues.apache.org/jira/browse/HBASE-17877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956303#comment-15956303
 ] 

Anoop Sam John commented on HBASE-17877:
----------------------------------------

Interesting.  The main change here is to avoid reverseBytes calls.  That is the 
thing giving the perf boost?
{code}
if (minLength - offset >= SIZEOF_INT) {         
......
1446              offset += SIZEOF_INT;         
1447            }               
1448            if (minLength - offset >= SIZEOF_SHORT) {
{code}
These were to avoid byte by byte read and check as much as possible after long 
reads.  So this is also a needed change?

> Replace/improve HBase's byte[] comparator
> -----------------------------------------
>
>                 Key: HBASE-17877
>                 URL: https://issues.apache.org/jira/browse/HBASE-17877
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Vikas Vishwakarma
>         Attachments: 17877-1.2.patch
>
>
> [~vik.karma] did some extensive tests and found that Hadoop's version is 
> faster - dramatically faster in some cases.
> Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to