[
https://issues.apache.org/jira/browse/HBASE-17877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958354#comment-15958354
]
Vikas Vishwakarma commented on HBASE-17877:
-------------------------------------------
Sure [[email protected]] [~Apache9] [~anoopsamjohn] [~lhofhansl], thanks for
the inputs
Will try to add the micro benchmarks using JMH
Will use 1 - 10 million iterations
The main difference in the two versions is related to the binary search using
the diff between the longs being compared in Hadoop version Vs doing
Long.reverseBytes and then comparing in HBase version. For the leftover bytes
after all the long compares, in my initial tests I had left it as it is in
HBase and then later on changed that to the hadoop implementation which uses
guava comparison but there was not much difference.
> Replace/improve HBase's byte[] comparator
> -----------------------------------------
>
> Key: HBASE-17877
> URL: https://issues.apache.org/jira/browse/HBASE-17877
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Vikas Vishwakarma
> Attachments: 17877-1.2.patch, 17877-v2-1.3.patch,
> ByteComparatorJiraHBASE-17877.pdf
>
>
> [~vik.karma] did some extensive tests and found that Hadoop's version is
> faster - dramatically faster in some cases.
> Patch forthcoming.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
