[
https://issues.apache.org/jira/browse/HBASE-17890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966016#comment-15966016
]
Chia-Ping Tsai commented on HBASE-17890:
----------------------------------------
bq. So here the test code explicitly calls the unsafe path or non unsafe path.
(Non public methods).. We should fix this?
The difference between the "unsafe" and "non unsafe" is the "mask".
|| ||unsafe||non unsafe||
|mask for fixed byte|-1|0|
The failure happen when some tests pass the mask which work for unsafe into the
non unsafe function. So i switch the mask according to the state of unsafe.
bq. As such this patch I felt difficult to read and understand.
Okay. Let me simplify it.
Thanks for the feedback. [~anoop.hbase]
> FuzzyRow tests fail if unaligned support is false
> -------------------------------------------------
>
> Key: HBASE-17890
> URL: https://issues.apache.org/jira/browse/HBASE-17890
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.0.0, 1.2.5
> Reporter: Jerry He
> Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.1.10, 1.2.6, 1.3.2
>
> Attachments: HBASE-17890.v0.branch-1.patch, HBASE-17890.v0.patch
>
>
> When unaligned support is false, FuzzyRow tests fail:
> {noformat}
> Failed tests:
> TestFuzzyRowAndColumnRangeFilter.Test:134->runTest:157->runScanner:186
> expected:<10> but was:<0>
> TestFuzzyRowFilter.testSatisfiesForward:81 expected:<YES> but was:<NO_NEXT>
> TestFuzzyRowFilter.testSatisfiesReverse:121 expected:<YES> but
> was:<NEXT_EXISTS>
> TestFuzzyRowFilterEndToEnd.testEndToEnd:247->runTest1:278->runScanner:343
> expected:<6250> but was:<0>
> TestFuzzyRowFilterEndToEnd.testFilterList:385->runTest:417->runScanner:445
> expected:<5> but was:<0>
> TestFuzzyRowFilterEndToEnd.testHBASE14782:204 expected:<6> but was:<0>
> {noformat}
> This can be reproduced in the case described in HBASE-17869. Or on a platform
> really without unaligned support.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
