[
https://issues.apache.org/jira/browse/HBASE-17890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968523#comment-15968523
]
Anoop Sam John commented on HBASE-17890:
----------------------------------------
Great! Thanks for the name changes (correction) . It is easy to read and
understand now.
{code}
if (!FuzzyRowFilter.UNSAFE_UNALIGNED) {
81 return;
82 }
{code}
Pls add some comment around this as this will be a NOOP test when no unsafe.
We specifically test the unsafe impl logic here and we have a nounsafe
counterpart test here which tests the actual code correctness when there is no
Unsafe avail in the system.
+1 ( U can add the comments on commit)
Thanks.
> FuzzyRow tests fail if unaligned support is false
> -------------------------------------------------
>
> Key: HBASE-17890
> URL: https://issues.apache.org/jira/browse/HBASE-17890
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.0.0, 1.2.5
> Reporter: Jerry He
> Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.1.10, 1.2.6, 1.3.2
>
> Attachments: HBASE-17890.v0.branch-1.patch, HBASE-17890.v0.patch,
> HBASE-17890.v1.branch-1.patch, HBASE-17890.v1.patch, HBASE-17890.v2.patch
>
>
> When unaligned support is false, FuzzyRow tests fail:
> {noformat}
> Failed tests:
> TestFuzzyRowAndColumnRangeFilter.Test:134->runTest:157->runScanner:186
> expected:<10> but was:<0>
> TestFuzzyRowFilter.testSatisfiesForward:81 expected:<YES> but was:<NO_NEXT>
> TestFuzzyRowFilter.testSatisfiesReverse:121 expected:<YES> but
> was:<NEXT_EXISTS>
> TestFuzzyRowFilterEndToEnd.testEndToEnd:247->runTest1:278->runScanner:343
> expected:<6250> but was:<0>
> TestFuzzyRowFilterEndToEnd.testFilterList:385->runTest:417->runScanner:445
> expected:<5> but was:<0>
> TestFuzzyRowFilterEndToEnd.testHBASE14782:204 expected:<6> but was:<0>
> {noformat}
> This can be reproduced in the case described in HBASE-17869. Or on a platform
> really without unaligned support.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
