[
https://issues.apache.org/jira/browse/HBASE-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030502#comment-16030502
]
Ted Yu commented on HBASE-18089:
--------------------------------
For the 2nd part of testImportanceOfHeartbeats :
{code}
HeartbeatRPCServices.heartbeatsEnabled = false;
try {
testCallable.call();
} catch (Exception e) {
return;
{code}
What might have happened where the test failed was that the call() returned
earlier than an exception could be thrown.
> TestScannerHeartbeatMessages fails in branch-1
> ----------------------------------------------
>
> Key: HBASE-18089
> URL: https://issues.apache.org/jira/browse/HBASE-18089
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: huaxiang sun
> Attachments: test-heartbeat-6860.out
>
>
> From
> https://builds.apache.org/job/PreCommit-HBASE-Build/6860/artifact/patchprocess/patch-unit-hbase-server.txt
> :
> {code}
> testScannerHeartbeatMessages(org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages)
> Time elapsed: 2.376 sec <<< FAILURE!
> java.lang.AssertionError: Heartbeats messages are disabled, an exception
> should be thrown. If an exception is not thrown, the test case is not
> testing the importance of heartbeat messages
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages.testImportanceOfHeartbeats(TestScannerHeartbeatMessages.java:237)
> at
> org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages.testScannerHeartbeatMessages(TestScannerHeartbeatMessages.java:207)
> {code}
> Similar test failure can be observed in
> https://builds.apache.org/job/PreCommit-HBASE-Build/6852/artifact/patchprocess/patch-unit-hbase-server.txt
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
