[ 
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178216#comment-13178216
 ] 

[email protected] commented on HBASE-4224:
------------------------------------------------------



bq.  On 2011-12-25 17:53:31, Ted Yu wrote:
bq.  > /src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line 1392
bq.  > <https://reviews.apache.org/r/3308/diff/2/?file=65853#file65853line1392>
bq.  >
bq.  >     I think Future.get(long timeout, TimeUnit unit) should be used here 
so that we don't wait indefinitely.

The flush would depend on the number of regions the Regions Server is hosting 
and ofcourse other system dependent factors. So how do we decide the timeouts. 
Secondly if the get times out then that RegionServer's WAL will not be rolled, 
as the logic to roll is on the client side currently. Could move this to server 
side so that roll happens after a flush ?


- Akash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3308/#review4116
-----------------------------------------------------------


On 2011-12-24 04:31:50, Akash  Ashok wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3308/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-24 04:31:50)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Flush by RegionServer
bq.  
bq.  
bq.  This addresses bug HBase-4224.
bq.      https://issues.apache.org/jira/browse/HBase-4224
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/ServerName.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1222902 
bq.  
bq.  Diff: https://reviews.apache.org/r/3308/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Akash
bq.  
bq.


                
> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
>                 Key: HBASE-4224
>                 URL: https://issues.apache.org/jira/browse/HBASE-4224
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: stack
>            Assignee: Akash Ashok
>         Attachments: HBase-4224-v2.patch, HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster.  logs are by 
> regionserver.  to let go of logs, we need to have all edits emptied from 
> memory.  only flush is by table or region.  We need to be able to flush the 
> regionserver.  Need to add this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to