[
https://issues.apache.org/jira/browse/HBASE-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037882#comment-16037882
]
Ted Yu commented on HBASE-17907:
--------------------------------
For the new RequestConverter::ToScanRequest() methods, the following is
repeated:
{code}
+ // TODO We will change this later.
+ pb_msg->set_client_handles_partials(false);
+ pb_msg->set_client_handles_heartbeats(false);
+ pb_msg->set_track_scan_metrics(false);
{code}
Can the above be extracted into a helper method ?
For AsyncClientScanner::CallOpenScanner():
{code}
+ VLOG(5) << "Calling RPC Client to open the scanner";
{code}
Please include loc->region_name(), etc in the log.
For ScanCallerBuilder :
{code}
+ typedef ScanCallerBuilder GenenericThisType;
{code}
The above type has typo (Geneneric).
For ScanResumerImpl::Resume(), what's the purpose for extra pair of curly's ?
{code}
+ {
+ std::unique_lock<std::mutex> mlock{mutex_};
{code}
The following local variable seems not used in ScanResumerImpl::Resume():
{code}
+ int64_t local_num_complete_rows;
{code}
> [C++] End to end Scans from Client/Table
> ----------------------------------------
>
> Key: HBASE-17907
> URL: https://issues.apache.org/jira/browse/HBASE-17907
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-17907-v1.patch, hbase-17907_v2.patch,
> hbase-scan-v0.patch
>
>
> Scan support from client, including the implementation for retrying RPCs,
> scanner management, scan result caching, prefetch, Client side interfaces and
> all related code.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
