[
https://issues.apache.org/jira/browse/HBASE-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037920#comment-16037920
]
Ted Yu commented on HBASE-17907:
--------------------------------
{code}
+std::string ScanControllerImpl::DebugString(ScanControllerState state) {
+std::string ScanControllerImpl::DebugString(ScanResumerState state) {
{code}
The above methods produce strings which seem to be identical for corresponding
states in controller and consumer. Consider distinguishing the states with
"controller" / "consumer".
{code}
+ VLOG(5) << "Scan: CompleteNoMoreResults";
{code}
Consider adding scanner_id, etc to the above log.
{code}
+void AsyncTableResultScanner::Close() {
+ std::unique_lock<std::mutex> mlock(mutex_);
+ closed_ = true;
+ while (!queue_.empty()) {
+ queue_.pop();
{code}
For the remaining elements in queue_, we can discard without further action ?
> [C++] End to end Scans from Client/Table
> ----------------------------------------
>
> Key: HBASE-17907
> URL: https://issues.apache.org/jira/browse/HBASE-17907
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-17907-v1.patch, hbase-17907_v2.patch,
> hbase-scan-v0.patch
>
>
> Scan support from client, including the implementation for retrying RPCs,
> scanner management, scan result caching, prefetch, Client side interfaces and
> all related code.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
