[ 
https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050263#comment-16050263
 ] 

Eshcar Hillel commented on HBASE-18010:
---------------------------------------

I left some comments on review board, will continue reviewing other parts.
I am not sure that extending the Segment hierarchy is the right decision.
>From briefly reviewing the code it seems that extending CellSet and/or adding 
>CellSetFactory is more appropriate.
But I will give more concrete comments when I get dipper into the code.  

> Connect CellChunkMap to be used for flattening in CompactingMemStore
> --------------------------------------------------------------------
>
>                 Key: HBASE-18010
>                 URL: https://issues.apache.org/jira/browse/HBASE-18010
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-18010-V04.patch
>
>
> The CellChunkMap helps to create a new type of ImmutableSegment, where the 
> index (CellSet's delegatee) is going to be CellChunkMap. No big cells or 
> upserted cells are going to be supported here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to