[ 
https://issues.apache.org/jira/browse/HBASE-17752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051315#comment-16051315
 ] 

Mike Drob commented on HBASE-17752:
-----------------------------------

{code}
+      final Map<String,Long> snapshotSizes = new HashMap<>();
{code}
Nit: Can we estimate the size of this map before construction?

{code}
+    assertEquals(actualInitialSize, size.longValue());
{code}
Good to have a message here describing the failure. (Both places)


Would be nice to have a test for the new shell command.

> Update reporting RPCs/Shell commands to break out space utilization by 
> snapshot
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-17752
>                 URL: https://issues.apache.org/jira/browse/HBASE-17752
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>         Attachments: HBASE-17752.001.patch, HBASE-17752.002.patch, 
> HBASE-17752.003.patch
>
>
> For adminstrators running HBase with space quotas, it is useful to provide a 
> breakdown of the utilization of a table. For example, it may be non-intuitive 
> that a table's utilization is primarily made up of snapshots. We should 
> provide a new command or modify existing commands such that an admin can see 
> the utilization for a table/ns:
> e.g.
> {noformat}
> table1:       17GB
>   resident:   10GB
>   snapshot_a: 5GB
>   snapshot_b: 2GB
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to