[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client

[Sean Busbey (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063143#comment-16063143
 ] 

Sean Busbey commented on HBASE-18268:
-------------------------------------

{code}
diff --git 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
index d414f7036b..a41fdff3e5 100644
--- 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
+++ 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
@@ -101,7 +101,7 @@ public abstract class AbstractRpcClient<T extends 
RpcConnection> implements RpcC
   private static final ScheduledExecutorService IDLE_CONN_SWEEPER = Executors
       .newScheduledThreadPool(1, 
Threads.newDaemonThreadFactory("Idle-Rpc-Conn-Sweeper"));
 
-  protected final static Map<Kind, TokenSelector<? extends TokenIdentifier>> 
TOKEN_HANDLERS = new HashMap<>();
+  final static Map<Kind, TokenSelector<? extends TokenIdentifier>> 
TOKEN_HANDLERS = new HashMap<>();
 
   static {
     TOKEN_HANDLERS.put(Kind.HBASE_AUTH_TOKEN, new 
AuthenticationTokenSelector());
{code}

This one I think we should add a javadoc comment and disable the findbugs 
complaint. It looks like we mean for this to be a point where RPC 
implementations on top of AbstractRpcClient can add additional TOKEN_HANDLERS 
that the rest of the system can then use. I'd rather not put a strong 
requirement on having those implementations live in the same package.

But AbstractRpcClient is IA.Private so we could always update this later I 
suppose. I'll leave if to your judgement.

I'm +1 with or without the suggested change to handling the TOKEN_HANDLERS 
warning.

> Eliminate the findbugs warnings for hbase-client
> ------------------------------------------------
>
>                 Key: HBASE-18268
>                 URL: https://issues.apache.org/jira/browse/HBASE-18268
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
>         Attachments: HBASE-18268.v0.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)