[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064159#comment-16064159
]
Chia-Ping Tsai commented on HBASE-18268:
----------------------------------------
bq. Not sure if it's in scope here or not, but some of the other PoolMap
methods also look suspect regarding return values.
Do you mean that some methods always return the null? For example:
{code}
@Override
public R put(R resource) {
if (super.size() < maxSize) {
add(resource);
}
return null;
}
{code}
{code}
@SuppressWarnings("unchecked")
@Override
public V remove(Object key) {
Pool<V> pool = pools.remove(key);
if (pool != null) {
removeValue((K) key, pool.get());
}
return null;
}
{code}
> Eliminate the findbugs warnings for hbase-client
> ------------------------------------------------
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
