[ 
https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075586#comment-16075586
 ] 

stack commented on HBASE-18106:
-------------------------------

Idea is to purge ProcedureInfo from our API. You'd have to deprecate it since 
it has been in API since before 2.0.

Add a method that returns an array of Strings, JSON Strings. Deprecate 
listProcedures in favor of getProcedures which returns String [] and ditto for 
listLocks and getLocks.

Unfortunately we have internally made use of ProcedureInfo to check owner.  
Would have to come up w/ something else or parse the json to find the owner 
key/value and compare that.

Serializing as JSON, you'd just serialize the protobuf. You'd probably have to 
filter out the serialized byte array of procedure data.

Use the protobuf-util which is available via 
hbase-thirdparty/hbase-shaded-miscellaneous. See comment higher up on how you 
might use it.


> Redo ProcedureInfo and LockInfo
> -------------------------------
>
>                 Key: HBASE-18106
>                 URL: https://issues.apache.org/jira/browse/HBASE-18106
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> ProcedureInfo was introduced as a lowest-common-denominator POJO that could 
> be used as a facade on PB Procedures. It was good for showing state of 
> Procedure framework in shell and UI.
> Its a bit weird though. Its up in hbase-common rather than in Procedure and 
> it can only ever show a subset of the Procedure info.
> I was thinking we could use the pb3.1 pb->JSON utility instead and emit a 
> JSON String wherever we need to export a view on procedure internals.
> This issue is about exploring this possibility. Would depend on our having an 
> upgraded guava (so probably depends on the 'pre-build' project).
> From ProcedureInfo and LockInfo need fixing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to